search

w3c / rdf-star

RDF-star specification
https://w3c.github.io/rdf-star/
Other
120 stars 23 forks source link

adding morph-kgc implementation #259

Closed dachafra closed 2 years ago

dachafra commented 2 years ago

If this implementation isn't suitable for the webpage, please let us know where we can contribute with it :-) Also closing tr and td tags in the table.

afs commented 2 years ago

To add an implementation, please put in a PR that is only for that purpose. No formatting changes. Then it is easier to include without having to review the whole page.

There are now two Apache Jena entries.

It is "Eclipse RDF4J", not "Eclipse".

w3cbot commented 2 years ago

gkellogg marked as non substantive for IPR from ash-nazg.

gkellogg commented 2 years ago

I agree with @afs; please add a commit which makes a minimal change to the original file, simply adding the new implementation without reformatting the existing code.

A separate PR can deal with any necessary reformatting or reordering of entries.

dachafra commented 2 years ago

Done, and sorry for the noise

afs commented 2 years ago

Hi @dachafra - looks good as the combined effect.

Could you squash the PR to one commit for the change? The git history will look better.

It's showing up to me as all the changes, then the reverse, in 6 commits.

pchampin commented 2 years ago

@afs github allows us to do this at merge time ("squash and merge"). This might be the easiest solution. @dachafra note however that if we do that your 'main' branch will diverge from our 'main' branch... As a general advice for the future: always create dedicated branches for your pull requests to other repositories, and keep synced branches clean of any change on your side.

afs commented 2 years ago

@pchampin yes, but.

It is clearer who the contributor is if the OP does the squash and force-pushes.

It's a detail to keep the history clean, not a blocker.