w3c / rdf-turtle

https://w3c.github.io/rdf-turtle/
Other
4 stars 4 forks source link

improve display on mobile phones #20

Closed domel closed 1 year ago

domel commented 1 year ago

Preview | Diff

pfps commented 1 year ago

@gkellogg See also https://github.com/w3c/rdf-semantics/pull/30

TallTed commented 1 year ago

In the Context where each kind of escape sequence can be used, the contrast between the dark-green background and the black text thereon is problematic. A relatively simple fix would be to use white text for these; alternatively, the background could be made a lighter green.

domel commented 1 year ago

@TallTed done

TallTed commented 1 year ago

The table in §2.5.2 Numbers would benefit greatly by narrowing the first 2 columns and passing that width to the 4th column. (The 3rd column is only slightly wider than its widest value, so should remain very close to the same width.)

Similarly, the 2nd column of the table in §7.2 RDF Term Constructors could pass some width to the 3rd.

In both cases, words are broken to wrap and keep the table close to if not smaller than the viewport. Better not to break words, and to overflow the viewport and need soome horizontal scrolling.

domel commented 1 year ago

@TallTed I'm not happy with hacking tables like this. IMO it should be decided by User Agent, but OK I hacked those tables you mentioned. Hope you like it now.

TallTed commented 1 year ago

If User Agents would do the right thing, I'd be happy to let them. Your latest changes don't seem to have had the intended effect.

§2.5.2 Numbers delivers (showing the whole table):

Screen Shot 2023-05-18 at 06 13 02 PM

§7.2 RDF Term Constructors delivers (showing the widest values of col1 and col2):

Screen Shot 2023-05-18 at 06 16 21 PM

Both tables still have wraps within words, in smaller viewports.

pfps commented 1 year ago

This PR has the effect of making the font size smaller for tables when the window with becomes small (but still over 1/2 of the width of my laptop's screen with what I consider to be a reasonable font size). This has the decidedly negative effect of making the tables harder to read. There does not appear to be any benefit to this for many, and probably all, of the tables as they could be rendered at the normal font size with no problems.

Here is an example: Screenshot from 2023-05-18 21-00-05

TallTed commented 1 year ago

Please be aware that I will be offline and unresponsive through May 30. That will not change my interest in getting this resolved in the best way for all, which it is not yet. I would have suggested not merging this PR, given the ongoing mixed feelings about its effect. I will suggest that there should be a new issue opened on this topic for the Turtle document, regardless of how the others stand.

pfps commented 1 year ago

See https://github.com/w3c/rdf-star-wg/issues/61