Closed igrigorik closed 8 years ago
SGTM. @toddreifsteck, any objections?
/cc @eliperelman @bzbarsky
If you really wanted to, you could even support both:
requestIdleCallback(IdleRequestCallback callback, unsigned long timeout);
requestIdleCallback(IdleRequestCallback callback, optional IdleRequestOptions options);
No idea whether you want that. Just having the dictionary is probably fine.
FWIW, given that we're working with clean slate here, I'd vote for dictionary only -- reduces confusion.
@igrigorik no objections. I'm also fine with dictionary-only.
Change uploaded to address this in #22
Perfect! LGTM
Resolved via #22, closing.
Problem: Current API signature takes an optional timeout value, which makes it impossible to extend this API in the future with other optional or required parameters.
Proposal: move timeout into an optional dictionary…