w3c / requestidlecallback

Cooperative Scheduling of Background Tasks
https://w3c.github.io/requestidlecallback/
Other
50 stars 19 forks source link

Add dependencies section to maintain citation references. #63

Closed rmcilroy closed 7 years ago

rmcilroy commented 7 years ago

Addressing comment on #59

rmcilroy commented 7 years ago

Ilya, I made this change as suggested, however the links to the HTML spec don't work properly. They link to the title page of the multi-page version, so the fragment identifiers don't point to anything on that page (they are in one of the sub-pages). Any ideas?

igrigorik commented 7 years ago

Paging @marcoscaceres @siusin for x-ref guidance.. :-)

rmcilroy commented 7 years ago

Comments addressed, thanks for the hints, that seemed to work.

igrigorik commented 7 years ago

Hmm, I'm seeing 4 warnings on this end. Preview: https://cdn.rawgit.com/rmcilroy/requestidlecallback/dependencies/index.html

image

Are you seeing same warnings?

rmcilroy commented 7 years ago

I don't see those errors. This PR shouldn't have changed those links either. Did you try with the non-cdn version of rawgit?

igrigorik commented 7 years ago

Yep, cmd-F5 and I still see them.

Ditto if I view the blob URL linked in this PR: https://github.com/rmcilroy/requestidlecallback/blob/ad7f456c52831d49be6a22bcc09a4dffc0546132/index.html

marcoscaceres commented 7 years ago

I'm also not seeing any errors on: https://cdn.rawgit.com/rmcilroy/requestidlecallback/dependencies/index.html

igrigorik commented 7 years ago

What the.. Something really odd is happening here then. I'm using incognito + CDT disable cache and I keep seeing the same error. Here's the trace HAR trace: https://gist.github.com/igrigorik/ffdb787e5ad16e456b94d89bf7a30fbb#file-ric-har-json-L166

Screenshot from devtools: image

igrigorik { ~ } > curl -s https://www.w3.org/Tools/respec/respec-w3c-common | md5 ffce5b58bff3c09934147abca2d7734a

marcoscaceres commented 7 years ago

Strange. Maybe let's just get this merged? If the warnings are still there, I can take over and do a markup cleanup and squash any remaining issues.

marcoscaceres commented 7 years ago

Seems good! No warnings on the gh-pages branch (https://w3c.github.io/requestidlecallback/).

🍾 to celebrate, I just used requestIdleCallback() in ReSpec to schedule some low priority stuff 😀

igrigorik commented 7 years ago

Bizarro.. @marcoscaceres I'm still seeing same errors =\

image

marcoscaceres commented 7 years ago

So super weird. I've tried in multiple browsers, cleared caches, etc. Here is a screenshot from Chrome Canary:

screenshot 2017-08-15 13 52 15

@rmcilroy or anyone else, can you confirm that it's working?

marcoscaceres commented 7 years ago

Here is Safari - showing cache disabled (and cache cleared) and also no warnings (forced lots reloads, just to be sure):

screenshot 2017-08-15 13 56 30

marcoscaceres commented 7 years ago

Also checked on a different computer in Edge. Seems happy there too.

Seems the interwebs is trolling you, @igrigorik.

igrigorik commented 7 years ago

/me facepalm.. apparently, it's Ghostery! As soon as I disable it, everything is a-OK. Apologies for the noise.

rmcilroy commented 7 years ago

Thanks everyone for investigating!

:champagne: to celebrate, I just used requestIdleCallback() in ReSpec to schedule some low priority stuff :grinning:

Awesome stuff :+1: