w3c / resource-timing

Resource Timing
https://w3c.github.io/resource-timing/
Other
119 stars 35 forks source link

Fix a link to the HR-TIME spec #308

Closed tommckee1 closed 2 years ago

tommckee1 commented 2 years ago

The current link goes to the HR-TIME spec but the URL fragment was missing a prefix so it didn't auto-scroll to the targeted definition.


Preview | Diff

tommckee1 commented 2 years ago

Looks like the Performance Timeline Level 2 spec needs to get referenced through 'performance-timeline', not 'performance-timeline-2' ... see https://respec.org/xref/?term=supportedEntryTypes ...🤷

Checks are green now 😄!

yoavweiss commented 2 years ago

Yeah, I think we recently removed the "-2"

tommckee1 commented 2 years ago

Gah! Didn't realize force-pushing to my github repo would update the PR here... working to revert now...

tommckee1 commented 2 years ago

Sorry for the noise hear Yoav 😅

Does this look mergeable now?

tommckee1 commented 2 years ago

I've added npm1's suggestion to reference HR-Time's definition without the data-cite attribute.

LMKWYT!