w3c / respec-vc

Verifiable Credential extensions to ReSpec
Other
3 stars 5 forks source link

Add eslint. #19

Closed BigBlueHat closed 6 months ago

BigBlueHat commented 6 months ago
BigBlueHat commented 6 months ago

Does w3c have a particular style they prefer? Or is it ok to use the digitalbazaar style for this? I'm of course fine with the digitalbazaar ways.

We've been using our style for years and no one's complained. Additionally, the W3C receives loads of code donations and enforcing a single style across all of that surface area would be a fools errand. So...it's not a problem we need to address here.

TallTed commented 6 months ago

fwiw, W3C Manual of Style

davidlehn commented 6 months ago

fwiw, W3C Manual of Style

That doesn't appear to cover preferred code styles.

BigBlueHat commented 6 months ago

@davidlehn added your tweaks. I did not change the package to type: module however, because the code isn't setup to load that way...and it's way more overhead to change it than is necessary at this point. The linting mostly passes now, and it's good enough to keep things on the rails for the present.

BigBlueHat commented 6 months ago

@davidlehn went ahead and merged this based on earlier review. Happy to keep tweaking...but can't keep being blocked by fiddly things (sorry).

TallTed commented 6 months ago

@davidlehn — It hasn't been updated since 2014, but maybe this Coding style wiki page helps.