w3c / respec-vc

Verifiable Credential extensions to ReSpec
Other
3 stars 5 forks source link

Add VC-JOSE-COSE Rendering (Take 2) #30

Closed decentralgabe closed 5 months ago

decentralgabe commented 5 months ago

Merge of https://github.com/w3c/respec-vc/pull/28 into current main

As a bonus, the key is no longer static...

decentralgabe commented 5 months ago

nudge nudge @msporny

msporny commented 5 months ago

Apologies, again, @decentralgabe -- don't know why I'm not getting notifications to review from Github. I'll have to look at my very aggressive inbox filters; review requests are probably getting filtered to the "github" inbox, which gets hundreds of notifications per day.

msporny commented 5 months ago

Checked locally, everything seems to work! Hooray! I'll get a new release out now so we can pull it into the VCWG specs.

One thing I noted was that the cose stuff seems broken? It doesn't seem to include the payload? (payload is nil). Is this expected behaviour?