search

w3c / respec-vc

Verifiable Credential extensions to ReSpec
Other
3 stars 5 forks source link

Support rendering Enveloped Verifiable Presentations #40

Closed decentralgabe closed 3 months ago

decentralgabe commented 3 months ago

fix #39

decentralgabe commented 3 months ago

@msporny will need your help creating a release in NPM, when you get a chance, please.

I created a github release here https://github.com/w3c/respec-vc/releases/tag/3.3.3

decentralgabe commented 3 months ago

so https://cdn.jsdelivr.net/gh/w3c/respec-vc@3.3.2/dist/main.js exists but https://cdn.jsdelivr.net/gh/w3c/respec-vc@3.3.3/dist/main.js does not

I am not sure how you got the dist folder and artifacts to be present for 3.3.2...

msporny commented 3 months ago

You have to build and check in the dist folder but ONLY on the tag (it becomes a disconnected branch commit). The way I do this is usually:

  1. Branch off on a release-3.3.3 branch.
  2. Build, add, and commit dist/main.js.
  3. Tag the latest commit and push the tag up to the repo.
  4. Go back to main and delete the release-3.3.3 branch w/o merging it.

If that doesn't make sense, we'll push your changes out when we fix the Echidna stuff. Let me check w/ @BigBlueHat if those changes are ready to go and I'll try to push a release out.

You /might/ be able to update the 3.3.3 tag w/ the dist/main.js checked in, but I have no idea if jsdelivr caches tag releases temporarily/permanently, or checks for hash changes? We might have to mark 3.3.3 as a broken tag release?

decentralgabe commented 3 months ago

thanks @msporny that worked -- https://cdn.jsdelivr.net/gh/w3c/respec-vc@3.3.3/dist/main.js