search

w3c / screen-wake-lock

Screen Wake Lock API
https://www.w3.org/TR/screen-wake-lock/
Other
85 stars 35 forks source link

Add security considerations section #338

Closed beaufortfrancois closed 2 years ago

beaufortfrancois commented 2 years ago

To address concerns raised by @reillyeon at https://github.com/w3c/screen-wake-lock/issues/335#issuecomment-1133133517, I'm adding a security considerations section to the screen brightness explainer.

@anssiko Please have a look

anssiko commented 2 years ago

@beaufortfrancois thanks much!

@rakuco PTAL

beaufortfrancois commented 2 years ago

This change allows us to remove some of the open questions.

Done. Thanks for catching!

beaufortfrancois commented 2 years ago

Please have another look with latest changes.

anssiko commented 2 years ago

@willmorgan I think that is worth noting in the explainer. And latest when the API is more fleshed out any hooks that may be needed for https://github.com/w3c/window-placement should be brought to the attention of folks working on that API by opening a new issue for a future enhancement.

beaufortfrancois commented 2 years ago

@anssiko Shall we merge? What are the next steps?

anssiko commented 2 years ago

Thanks @beaufortfrancois @willmorgan.

With two reviews I think we’re good to merge this. I’m sure @rakuco is happy too and if he has further refinements we’ll get them in as we iterate.

As for the next steps for the proposal overall, we’re at https://github.com/w3c/screen-wake-lock/issues/335#issuecomment-1131665630