w3c / scribejs

Converter of RRSAgent IRC logs into minutes in markdown
https://w3c.github.io/scribejs/BrowserView/
Other
11 stars 14 forks source link

Fix the build in various ways, and update all dependencies #45

Closed tripu closed 6 years ago

tripu commented 6 years ago

I also reactivated builds on travis-ci.org (they were suspended)

BigBlueHat commented 6 years ago

Sorry for missing the .travis.yml!

I'm πŸ‘ on all these changes except npx which is failing for me--though node still works fine for the tests.

Beyond that, these seem sensible. πŸ˜ƒ

BigBlueHat commented 6 years ago

FWIW, here are my current version numbers:

tripu commented 6 years ago

Thanks to both of you for reviewing.

Before merging: @BigBlueHat, what's that error with npx? Can you try these commands in the project directory, please, and report back:

npm i
npx .       # should return "Scribejs Error..."
npx . -h    # should print Scribejs help

For me, npx -v returns exactly the same as npm -v; I don't understand how you get those versions…

@iherman, I take it that checking out this branch, installing dependencies and running the test suite works fine for you?

iherman commented 6 years ago

@tripu, yes, of course.

BigBlueHat commented 6 years ago

I just did a fresh install of Node.js 8.11.3 LTS, and these are my version numbers:

Curious what versions you're seeing @tripu.

Regardless, the npm i, npx ., and npx . -h all work as expected, but npm test still fails (when using npx as in this PR) with the following output:

$ npm test

> scribejs@1.1.0 test C:\Users\byoung2\dev\json-ld\scribejs
> mocha

  Basics
    Node.js
      1) exists
    scribejs
      2) returns an error with no params
      3) dumps help with β€œ-h”

  CLI usage
    4) can read log from a local file
    5) can dump result to a local file

  0 passing (30ms)
  5 failing

  1) Basics
       Node.js
         exists:
     Uncaught Error: spawn npx ENOENT
      at _errnoException (util.js:992:11)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:190:19)
      at onErrorNT (internal/child_process.js:372:16)
      at _combinedTickCallback (internal/process/next_tick.js:138:11)
      at process._tickCallback (internal/process/next_tick.js:180:9)

  2) Basics
       scribejs
         returns an error with no params:
     Uncaught Error: spawn npx ENOENT
      at _errnoException (util.js:992:11)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:190:19)
      at onErrorNT (internal/child_process.js:372:16)
      at _combinedTickCallback (internal/process/next_tick.js:138:11)
      at process._tickCallback (internal/process/next_tick.js:180:9)

  3) Basics
       scribejs
         dumps help with β€œ-h”:
     Uncaught Error: spawn npx ENOENT
      at _errnoException (util.js:992:11)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:190:19)
      at onErrorNT (internal/child_process.js:372:16)
      at _combinedTickCallback (internal/process/next_tick.js:138:11)
      at process._tickCallback (internal/process/next_tick.js:180:9)

  4) CLI usage
       can read log from a local file:
     Uncaught Error: spawn npx ENOENT
      at _errnoException (util.js:992:11)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:190:19)
      at onErrorNT (internal/child_process.js:372:16)
      at _combinedTickCallback (internal/process/next_tick.js:138:11)
      at process._tickCallback (internal/process/next_tick.js:180:9)

  5) CLI usage
       can dump result to a local file:
     Uncaught Error: spawn npx ENOENT
      at _errnoException (util.js:992:11)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:190:19)
      at onErrorNT (internal/child_process.js:372:16)
      at _combinedTickCallback (internal/process/next_tick.js:138:11)
      at process._tickCallback (internal/process/next_tick.js:180:9)

npm ERR! Test failed.  See above for more details.

If y'all want to move ahead with this commit, feel free. I'll just switch stuff back to node in the tests for me locally...though I guess others may have this issue to...eventually.

BTW, this error is the same in bash or PowerShell (as I'm on Windows).

tripu commented 6 years ago

Merging, since @iherman approved and @BigBlueHat was happy with this despite that weird error he gets about npx .. (If others report the same problem, I'll investigate and in the meantime make the test suite call npm . again.)