search

w3c / scribejs

Converter of RRSAgent IRC logs into minutes in markdown
https://w3c.github.io/scribejs/BrowserView/
Other
11 stars 14 forks source link

Lint “lib/” and “test/” too; fix errors there; check linting on Travis #51

Closed tripu closed 6 years ago

tripu commented 6 years ago

To examine actual changes here post-#50, review this diff instead.

TODO: lint CGI/ too and fix errors there!

:warning: To be merged after #50 is merged.

iherman commented 6 years ago

@tripu I presume the travis problems are related to the fact that this should come after the other PR, right?

tripu commented 6 years ago

“I presume the travis problems are related to the fact that this should come after the other PR, right?”

@iherman, it was some weird error on the part of Travis. I just restarted that one job that had failed, and it succeeded this time.

iherman commented 6 years ago

@tripu, o.k.

Having looked at the proposed changes, they are fine with me, although I was not sure of the logic or rearranging some functions in one of the files...

tripu commented 6 years ago

“I was not sure of the logic or rearranging some functions in one of the files...”

@iherman, I think it was the rule no-use-before-define the one that was triggering; some functions were invoked before they were defined in the file. I moved those function definitions. (It's not an error in JS, but with the arrival of new block-level keywords let and const it's better to have definitions before usage always, including var statements and function declarations, for consistency.)