Added schema validation for nicknames

w3c / scribejs

Converter of RRSAgent IRC logs into minutes in markdown

https://w3c.github.io/scribejs/BrowserView/

Other

11 stars 14 forks source link

Added schema validation for nicknames #67

Closed iherman closed 5 years ago

iherman commented 5 years ago

That turned out to be relatively easy addition:-)

Fix #66

iherman commented 5 years ago

Only caveat: the nickname schema is textually added to the js file rather than fetched from some login. As this schema should not change, doing a fetch for this every time looked like an overkill...

BigBlueHat commented 5 years ago

Requiring the JSON would be the only change I'd make in this PR--which I can also do as a follow-up if you'd prefer. Moving nicknames.json to use an object (going forward) would be a larger/future change...obviously.

BigBlueHat commented 5 years ago

Looks good to me!