w3c / scribejs

Converter of RRSAgent IRC logs into minutes in markdown
https://w3c.github.io/scribejs/BrowserView/
Other
11 stars 14 forks source link

Schema data to minutes #74

Closed iherman closed 5 years ago

iherman commented 5 years ago

This PR is not yet ready to merge, needs some bugs to be found, but need @BigBlueHat for this...

I have created a test version of the latest minutes in:

https://github.com/w3c/json-ld-wg/blob/master/Misc/test_minutes.md

However, when I look at this file via jekyll (https://www.w3.org/2018/json-ld-wg/Misc/test_minutes) I see two anomalies, both are jekyll related:

You are much better in jekyll than I am, so I would prefer you look at it and tell me what must be changed on the scribe.js code; I tried to compare the generated minutes with the one in index.md of the json-ld wg home page, and I do not see the difference. Can you look at this?

iherman commented 5 years ago

@BigBlueHat I found the issue: the schema data must be indented otherwise jekyll believes the start of the data is a new directive...

iherman commented 5 years ago

You can look at https://www.w3.org/2018/json-ld-wg/Misc/test_minutes to see the result

BigBlueHat commented 5 years ago

@BigBlueHat I found the issue: the schema data must be indented otherwise jekyll believes the start of the data is a new directive...

Yeah, it was probably outputting invalid YAML because of the whitespace... 😝

Glad you found it!