OMS alignment table - Githubissues

w3c / sdw-sosa-ssn

Repository of the Spatial Data on the Web Working Group for the SOSA/SSN vocabulary

7 stars 5 forks source link

OMS alignment table #139

Closed dr-shorthair closed 6 months ago

dr-shorthair commented 6 months ago

See https://raw.githack.com/w3c/sdw-sosa-ssn/oms-alignment-links/ssn/index.html#OMS-Alignment-Class

Closes #138

dr-shorthair commented 6 months ago

@sgrellet yes that is an error. Removed in ccbcc34

KathiSchleidt commented 6 months ago

I've now gone through the alignment (good work!), found a few glitches:

sosa:deployedSystem -> obs-cpt:Deployment/observer-sem
sosa:hasResult -> /req/sam-cpt/Sampling/sample-sem
sosa:implements -> /req/sam-cpt/PreparationStep/processingDetails-sem

A general note on the properties of Observation vs. ObservationCharacteristics - from what I see, sometimes mapped to one, othertimes to the other. To my view, should always be mapped to both (or we need to define Observation as a specialization of ObservationCharacteristics). (first noticed on sosa-oms:observationType, but applicable to all.

Then a few questions on potential gaps:

I see ultimateFoI, but no proximate. Is this on purpose (e.g. proximate = FoI), or an oversight?
While properties are aligned with ObservationCharacteristics, ObservationCharacteristics is never declared
SampleCollection is included, but ObservationCollection is missing.

KathiSchleidt commented 6 months ago

Now started in on sosa-oms.ttl, getting confused! Where does ActuationProcedure come from? Should be discussed!

dr-shorthair commented 6 months ago

@KathiSchleidt said

To my view, should always be mapped to both (or we need to define Observation as a specialization of ObservationCharacteristics). (first noticed on sosa-oms:observationType, but applicable to all.

When I raised this earlier, the suggestion was to map to the highest abstraction level possible. I'm inclined to agree that all mappings should be given, but this will be a change from the original agreement.

dr-shorthair commented 6 months ago

@KathiSchleidt

Where does ActuationProcedure come from?

This was not from OMS but trivially implied by the OMS procedure specializations, so added for symmetry. See note here https://raw.githack.com/w3c/sdw-sosa-ssn/oms-alignment-links/ssn/index.html#OMSActuationProcedure

This should be raised as a separate issue.

KathiSchleidt commented 6 months ago

Sorry for the misunderstanding pertaining to the ObservationCharacteristics, my bad!

dr-shorthair commented 6 months ago

@KathiSchleidt I think these concerns are fixed in https://github.com/w3c/sdw-sosa-ssn/commit/7673a2ab5550c909a6764f94028be88a0c5bc163

Please check https://raw.githack.com/w3c/sdw-sosa-ssn/oms-alignment-links/ssn/index.html#OMS-Alignment-Class and verify doc is OK.

If satisfied, please approve merge

dr-shorthair commented 6 months ago

@KathiSchleidt and @sgrellet can you confirm this is ready to merge please (review).

dr-shorthair commented 6 months ago

@rob-metalinkage I've attempted to address this in 979cad0f9603a59df0f56bef9c7602446c524628

dr-shorthair commented 6 months ago

@sgrellet @rob-metalinkage Can you click the review button and approve? I can't merge without that.

KathiSchleidt commented 6 months ago

@dr-shorthair sorry for the delay. Now managed to chew through the updates, one still missing:

ssn:deployedSystem: deployed system - Relation between a Deployment and a deployed System.

is currently mapped to

obs-cpt:Deployment/host-sem: The Host to which this Deployment pertains.

should be

obs-cpt/Deployment/observer-sem: The Observer associated with this Deployment.

Then should all be good to go :)

dr-shorthair commented 6 months ago

@KathiSchleidt thanks - good catch - fixed with https://github.com/w3c/sdw-sosa-ssn/pull/139/commits/67f6e67fcebc6e962d568120e6fc4714b0b347c1

KathiSchleidt commented 6 months ago

Perfect!