w3c / sdw-sosa-ssn

Repository of the Spatial Data on the Web Working Group for the SOSA/SSN vocabulary
7 stars 5 forks source link

Actuations results #184

Closed dr-shorthair closed 5 months ago

dr-shorthair commented 5 months ago

Preview at https://raw.githack.com/w3c/sdw-sosa-ssn/actuations-results/ssn/index.html#SOSAActuation https://raw.githack.com/w3c/sdw-sosa-ssn/actuations-results/ssn/index.html#SOSAhasResult https://raw.githack.com/w3c/sdw-sosa-ssn/actuations-results/ssn/index.html#SOSAresultTime https://raw.githack.com/w3c/sdw-sosa-ssn/actuations-results/ssn/index.html#SOSAphenomenonTime https://raw.githack.com/w3c/sdw-sosa-ssn/actuations-results/ssn/index.html#SOSAActuationCollection

Closes #176 #174 #162 #112

dr-shorthair commented 5 months ago

New property: startTime or initiationTime?

This would make alignment with PROV easier too.

dr-shorthair commented 5 months ago

Added startTime.

Preview at https://raw.githack.com/w3c/sdw-sosa-ssn/actuations-results/ssn/index.html#SOSAActuation https://raw.githack.com/w3c/sdw-sosa-ssn/actuations-results/ssn/index.html#SOSAhasResult https://raw.githack.com/w3c/sdw-sosa-ssn/actuations-results/ssn/index.html#SOSAresultTime https://raw.githack.com/w3c/sdw-sosa-ssn/actuations-results/ssn/index.html#SOSAstartTime https://raw.githack.com/w3c/sdw-sosa-ssn/actuations-results/ssn/index.html#SOSAphenomenonTime https://raw.githack.com/w3c/sdw-sosa-ssn/actuations-results/ssn/index.html#SOSAActuationCollection

ldesousa commented 5 months ago

In general I see nothing major, just the wording above. However, I would still recommend an additional object property (e.g. hasExpectResult). It might clutter the parent class (Activity ?) but clears the semantics in the Actuation graph.

Another way of tackling this would be to feature hasResult only in the concrete graphs/modules and not in SOSA-Core.

dr-shorthair commented 5 months ago

This PR must be merged prior to the new modularization work suggested in https://github.com/w3c/sdw-sosa-ssn/issues/183#issuecomment-1913860023

dr-shorthair commented 5 months ago

In general I see nothing major, just the wording above. However, I would still recommend an additional object property (e.g. hasExpectResult). It might clutter the parent class (Activity ?) but clears the semantics in the Actuation graph.

Another way of tackling this would be to feature hasResult only in the concrete graphs/modules and not in SOSA-Core.

Lets look at this as a separate issue, and merge the work already done here.

alexrobin commented 5 months ago

I'm good with the PR but I noticed the following details:

But maybe the plan is to move these properties to the parent class Execution anyway...