Moved Sample and Procedure specializations to SOSA

w3c / sdw-sosa-ssn

Repository of the Spatial Data on the Web Working Group for the SOSA/SSN vocabulary

7 stars 5 forks source link

Moved Sample and Procedure specializations to SOSA #185

Closed dr-shorthair closed 5 months ago

dr-shorthair commented 5 months ago

Also move resultQuality and relatedObservation to SOSA

Closes #132

dr-shorthair commented 5 months ago

Preview at https://raw.githack.com/w3c/sdw-sosa-ssn/132-move-extra-oms-terms-into-sosa-core/ssn/index.html#Sampling https://raw.githack.com/w3c/sdw-sosa-ssn/132-move-extra-oms-terms-into-sosa-core/ssn/index.html#Procedures https://raw.githack.com/w3c/sdw-sosa-ssn/132-move-extra-oms-terms-into-sosa-core/ssn/index.html#OMS-Alignment-Class etc

dr-shorthair commented 5 months ago

This PR must be merged prior to the new modularization work suggested in https://github.com/w3c/sdw-sosa-ssn/issues/183#issuecomment-1913860023

alexrobin commented 5 months ago

I'm good with this PR overall, but I have two questions:

Does it make sense to bring PreparationProcedure into sosa namespace if we are not bringing PreparationStep?
Should the range of usedProcedure on Observation/Actuation/Sampling be adjusted to allow only the specialized procedure classes?

dr-shorthair commented 5 months ago

Does it make sense to bring PreparationProcedure into sosa namespace if we are not bringing PreparationStep?

Should the range of usedProcedure on Observation/Actuation/Sampling be adjusted to allow only the specialized procedure classes?

Thanks @alexrobin - fixed these. Can you now approve merge?

@hylkevds @sgrellet @KathiSchleidt can you approve please?