w3c / sdw-sosa-ssn

Repository of the Spatial Data on the Web Working Group for the SOSA/SSN vocabulary
7 stars 5 forks source link

Retire Sample Relations module #188

Open dr-shorthair opened 5 months ago

dr-shorthair commented 5 months ago

Non-normative Was only ever a thought bubble ...

sgrellet commented 5 months ago

Sorry I missed the session yesterday (was commuting between DK and FR). Maybe I'm reading this wrong, but we need to keep the relatedSample for many domains. And actually it's something we have in OMS in the Conceptual Sample schema model(see image below).

Happy to elaborate on why we need to keep this. But I prefer a light contribution, in case I got this issue wrong

image

dr-shorthair commented 5 months ago

The SampleRelations modules is different to the OMS relatedSample property. It has an association-class that can carry a role explaining the nature of the relationship. (this is a standard 'pattern'.)

But to my knowledge it has not been used or deployed anywhere, so is pretty much an orphan where it is - https://www.w3.org/TR/vocab-ssn/#Sample_Relations

hylkevds commented 5 months ago

The OMS the related* relations all have a context for this role information.

In STA 2.0 we're planning a relation extension that has (among others) a RelatedFeature EntityType, since a Sample is just a specific type of Feature: Datamodel-SensorThingsApi-V2-Relations drawio

Also included: RelatedDatastream, RelatedObservation and RelatedThing.

I guess it may be useful to move this to the Feature level

dr-shorthair commented 4 months ago

I was looking at https://docs.ogc.org/as/20-082r4/20-082r4.html#_conceptual_sample_schema_model The relatedSample association is direct, not an association class. Same for all the other relatedXXX associations.

We don't have a general Feature class in SSN, only FeatureOfInterest. So the Procedures, Executions, Systems etc do not have a common superclass to tie such a general association class onto. And I don't want to get into doing a general application-schema model in the context of SSN, though (i.e. along the lines of ISO 19109). We leave domain modeling to the domains. That's why FoI is a very sparse class.

Note that @kjano has proposed factoring out the Foi/Property part of the ontology into its own module - https://github.com/w3c/sdw-sosa-ssn/issues/191#issuecomment-1926568292

hylkevds commented 4 months ago

But there is this extra box attached to that relation: context:GenericName.

11.2.6. Association relatedSample Requirement /req/sam-cpt/Sample/relatedSample-sem A Sample the Sample is related to. If a reference to a related Sample is provided, the association with role relatedSample shall be used. The context:GenericName qualifier of this association may be used to provide further information as to the nature of the relation.

dr-shorthair commented 4 months ago

OK - I see that now. I didn't understand the UML idiom.

Yes, this clearly matches the Sample Relations ontology extension. So is /req/sam-cpt/Sample/relatedSample-sem better related to https://www.w3.org/TR/vocab-ssn/#SAMPhasSampleRelationship ?

sgrellet commented 4 months ago

yes. That's why I was surprised in the first place

With our work on Water Quality I think we may be able to provide proof of implementation

hylkevds commented 3 months ago

The reason STA doesn't have a specific relatedSample class is because STA doesn't have a specific Sample class. There are relatedThing, relatedObservation and relatedDatastream classes. So if STA had a Sample class it probably also would have had a relatedSample class.

sgrellet commented 3 months ago

maybe the discussion about this in today's telco is more triggered by update procedures (here W3C is a bit different than OGC/ISO) than anything else.

several of us do know that we need to embark relatedObservation, relatedSample, relatedCollection (actually sosa:hasMember) etc... to answer to the use cases we face daily

but so far, the only short term proof of implementation we'll be able to provide will be under the OMS, STA paradigm. provided we have a STA - JSON-LD output we could provide that proof of implementation (but maybe more medium term).

how do we do until then ?

You guys have more W3C spec experience than I do.

KathiSchleidt commented 3 months ago

Just checking the relatedXXX associations on OMS, all 3 have the context on the association:

Does this mean we have to update the other relatedXXX?

dr-shorthair commented 3 months ago

You will recall that we added relatedObservation into SOSA, partly because OMS wants it, but also to support connections from Actuation and ActuationCollection to Observations that verify the value of the actuated property. It is a simple property - no role or relationship-nature.

Arguably there should be a general capability relatedFeature or relatedEntity (as suggested by @hylkevds) which could come from the OGC/ISO 'General Feature Model' layer. And, unless additional capabilities are needed for specific contexts, then there may be no need for specific properties. Except the GFM doesn't exist in RDF and establishing it is definitely beyond the scope of SSN. (Yes, I know we now have the FeatureOfInterest terms in SOSA-Common, but I'm reluctant to overload that further.)

(But as ever the choice of when to add a specialized property is something of an art. )

There is no harm in retaining the Sample Relations extension. It was already in the 2017 edition after all, labelled non-normative. While many of the cases mentioned could also be captured through isSampleOf relations, having a shorthand way to record the relationship-nature rather than through a Sampling with its SamplingProcedure and Sampler could be useful. But we can't promote it so normative without implementation evidence.

dr-shorthair commented 3 months ago

Propose closing this with no action

dr-shorthair commented 2 months ago

However, perhaps we should retire the extra namespace and use sosa: for this capability?

dr-shorthair commented 1 month ago

Should we move the sample-relations terms into sosa: ?

dr-shorthair commented 1 month ago

Probably beyond the scope of SSN core concerns. Leave in extension module.

Related to #36.