search

w3c / secure-payment-confirmation

Secure Payment Confirmation (SPC)
https://w3c.github.io/secure-payment-confirmation/
Other
110 stars 39 forks source link

Editorial: To address issue 140 #148

Closed ianbjacobs closed 2 years ago

ianbjacobs commented 2 years ago

Editorial. Addresses #140.

Preview | Diff

ianbjacobs commented 2 years ago

@samuelweiler, thanks for the review and additional comment. I hope this update does the trick.

samuelweiler commented 2 years ago

this resolves the suggestion.

One additional suggestion: especially since "cryptogram" isn't really defined in the spec, can you provide a citation back to the verification algorithm - show where this check is performed? (8.1, #2, #5? Also, should the sub-steps have letters instead of numbers?) And maybe a different term is still more appropriate?

I also think there are more opportunities for trimming some words, though it's not necessary.

ianbjacobs commented 2 years ago

@samuelweiler,

You mentioned a citation back to the verification algorithm. The proposed text includes a link to "8.1" but uses different verbiage to refer to that section. (Also, I did not not find other references to "verifying the cryptogram", so this seems to be the only one.)

I hope this address your request for a citation.

samuelweiler commented 2 years ago

Looks good to me.