Add option to allow instrument icon download fail

w3c / secure-payment-confirmation

Secure Payment Confirmation (SPC)

https://w3c.github.io/secure-payment-confirmation/

Other

113 stars 40 forks source link

Add option to allow instrument icon download fail #171

Closed nickburris closed 2 years ago

nickburris commented 2 years ago

This adds an option to the SecurePaymentConfirmationRequest for the developer to allow the credential to still be authenticated if the payment instrument icon fails to download or decode. This is done by adding an attribute iconMustBeShown to the PaymentCredentialInstrument.

The algorithms to check, display, and respond to a request are updated accordingly.

Issue #125

Preview | Diff

rlin1 commented 2 years ago

Looks good to me.

nickburris commented 2 years ago

Thanks for the suggestions & reviews! Will leave this open for 1 more week.

nickburris commented 2 years ago

Thanks all! Going to merge this one now.