search

w3c / secure-payment-confirmation

Secure Payment Confirmation (SPC)
https://w3c.github.io/secure-payment-confirmation/
Other
113 stars 40 forks source link

Use an hyphenated version of the SPC Transaction Mode enumeration values #231

Closed javifernandez closed 11 months ago

javifernandez commented 1 year ago

According to the Web Platform Design Principles the enumeration values should be defined in the "Lowercase, dash-delimited" form.

I've recently defined a new Web Driver command, inspired by the Set SPC Transaction Mode command defined in this spec, for the Custom Handler feature. The new Set RPH Registration Mode command values are defined according to the mentioned rules: auto-accept and auto-reject.

Is there any reason or specific need in the spec to avoid following the design principle casting rules ? Would make sense to have a common solution for both web driver commands.

As a mater of fact, I've recently landed a CL for the Chrome Dev Tools so that both command's implementation for Chromedriver use the same enum. This shared enum still uses the camelCase version, so it'd should be a matter of changing it to use the hyphenated version instead.

Preview | Diff

stephenmcgruer commented 1 year ago

Hi there :)

This was recently discussed in https://github.com/w3c/secure-payment-confirmation/issues/219, and the conclusion was that for webdriver parameters, camelCase was correct. Please give that issue a read through, and if you still disagree then maybe we can re-open it and discuss there (or maybe it becomes a topic for the webdriver spec itself)

ianbjacobs commented 1 year ago

@javifernandez are you ok if we close this issue with no changes?

javifernandez commented 1 year ago

@javifernandez are you ok if we close this issue with no changes?

I'm not sure we have got the consensus we aimed for in the WebDriver related discussion. It seems that we all agree on implementing whatever is decided; @annevk is also open to accept any proposal from the WebDriver people. I guess we would just need some confirmation there.

javifernandez commented 11 months ago

We have agreed to use camelCase so we can close this issue now.