search

w3c / secure-payment-confirmation

Secure Payment Confirmation (SPC)
https://w3c.github.io/secure-payment-confirmation/
Other
106 stars 48 forks source link

Relax user activation requirement for authentication #236

Closed nickburris closed 1 year ago

nickburris commented 1 year ago

See issue #216 for context. This removes the only reference to user activation for SPC authentication, and adds some spec text giving the user agent the option to skip or relax the user activation requirement in the PaymentRequest.show() steps.

Preview | Diff

nickburris commented 1 year ago

Thanks for the feedback @stephenmcgruer and @ianbjacobs! PTAL at the latest text. The CI failure seems unrelated to this change, it's a warning about the WPT that was recently added, which we can add a reference to in a separate commit.

stephenmcgruer commented 1 year ago

The CI failure seems unrelated to this change, it's a warning about the WPT that was recently added, which we can add a reference to in a separate commit.

Landed a fix for this straight to main, and have set the CI to re-run, hopefully it should pass now.

stephenmcgruer commented 1 year ago

Bleh, it still fails, probably because its using the PR's HEAD^ which won't contain the latest change I guess. Not a big deal, I agree that we can just ignore it for this PR (it will fix itself on main).

nickburris commented 1 year ago

Thanks! Addressed all comments and rebased to fix CI, this should be good to go now!

stephenmcgruer commented 1 year ago

Still LGTM, thanks Nick.