Closed github-actions[bot] closed 3 years ago
@marcoscaceres : how do we fix the PR contribution warning?
Why should this be a separate PR instead of a linter that blocks merging?
And BTW, the Travis CI thing should be removed from the required status list and GH action should be added instead. (Settings->Branches->main->...)
@vivienlacourba @dontcallmedom is it possible to stop the IPR complaints about @github-actions, please?
Thanks for removing Travis CI, could you add the GitHub Action to the required status, since it includes validation?
I don't think @github-actions triggers another GitHub action, so it could be another problem.
at the moment, the only way to avoid the IPR check would be to mark github-actions
as always OK, which, for a bot, would mean we're sure it will never be used to make a substantive change. I'm not sure how robust that assumption would be… But maybe the IPR bot could detect white-space only changes to deal with that particular usage? @siusin can you file an issue towards that in https://github.com/w3c/ash-nazg/issues ?
Thanks for removing Travis CI, could you add the GitHub Action to the required status, since it includes validation?
Sorry for my ignorance. How do I do that?
Sorry for my ignorance. How do I do that?
I think you did, thanks!
Oh BTW, "Tidy up" shouldn't be there since it never runs on PRs. (It works only after merging)
"Build and Validate" not running here shows what I said in https://github.com/w3c/selection-api/pull/140#issuecomment-859616116. The workaround is closing-and-reopeninng PRs from @github-actions, but I think linting should generally not open any additional PR?
Oh BTW, "Tidy up" shouldn't be there since it never runs on PRs. (It works only after merging)
Done.
"Build and Validate" not running here shows what I said in #140 (comment). The workaround is closing-and-reopeninng PRs from @github-actions, but I think linting should generally not open any additional PR?
Ok, I'm gonna merge this manually for now.
Late to the party here, but looks like everything is sorted 🎉
Late to the party here, but looks like everything is sorted 🎉
I think https://github.com/w3c/selection-api/pull/140#issuecomment-860134758 still matters. It needs an explicit GH token or it will not run w3c/spec-prod when opening PRs.
@saschanaz, you asked:
Why should this be a separate PR instead of a linter that blocks merging?
It's usually not worthwhile bothering random contributors to install tidy/run, as it just further discourages contributions. It's also means that one can't make quick edits directly on GitHub.
It needs an explicit GH token or it will not run w3c/spec-prod when opening PRs.
I minted one and saved it as "GH_TOKEN" in the secrets. Feel free to use 😊.
@saschanaz, you asked:
Why should this be a separate PR instead of a linter that blocks merging?
It's usually not worthwhile bothering random contributors to install tidy/run, as it just further discourages contributions. It's also means that one can't make quick edits directly on GitHub.
Reasonable, but could it instead push the change to each PR rather than opening a new one after merging? 🤔
It needs an explicit GH token or it will not run w3c/spec-prod when opening PRs.
I minted one and saved it as "GH_TOKEN" in the secrets. Feel free to use 😊.
👍
Reasonable, but could it instead push the change to each PR rather than opening a new one after merging?
Absolutely! And I encourage you to experiment. The (very limited/quick) thing I put together is what what was working for me over on some other repos. But, by all means, if you come up with something better, please add (share)!
Automated changes by create-pull-request GitHub action
Preview | Diff