Fire selectionchange on input/textarea elements

saschanaz commented 3 years ago

Closes (partially) #53, since this only covers selectionchange without selectstart because of no implementation.

Closes #75.

This follows the suggestion from @smaug---- - to bubble up from text controls to document, since it allows to easily detect which text control fired it.

(document.activeElement can be used in some cases to detect the source, but it's not always useful since it can be fired without focusing, e.g. through .setSelectionRange().)

The following tasks have been completed:

[ ] Modified Web platform tests (link to pull request) -

Implementation commitment:

[ ] WebKit (https://bugs.webkit.org/show_bug.cgi?id=)
[ ] Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=) @tkent-google?
[x] Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=1648944) @smaug---- @masayuki-nakano @annevk

Preview | Diff

saschanaz commented 3 years ago

@rniwa Sorry to ping you repeatedly for GitHub Action issue. The GitHub action changed its name to "Validate and Publish" from "Build and Validate" by #138, so it needs to be changed in the Settings page too.

tkent-google commented 3 years ago

Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=) @tkent-google?

I support this change.

marcoscaceres commented 3 years ago

@saschanaz, I gave you admin rights on the repo also. Hope that helps!

foolip commented 2 years ago

Looks like https://bugs.webkit.org/show_bug.cgi?id=234348 is the WebKit bug for this.

@tkent-google did you file a Chromium bug?

tkent-google commented 2 years ago

@tkent-google did you file a Chromium bug?

I have just filed https://bugs.chromium.org/p/chromium/issues/detail?id=1327098 .

w3c / selection-api

Fire selectionchange on input/textarea elements #141