search

w3c / selection-api

Selection API
http://w3c.github.io/selection-api/
Other
47 stars 30 forks source link

Change addRange (closes #80) #81

Closed yoichio closed 7 years ago

yoichio commented 7 years ago

Change addRange spec to keep existing range. Also update notes about current compatibility.

rniwa commented 7 years ago

Addresses https://github.com/w3c/selection-api/issues/80.

rniwa commented 7 years ago

Please add yourself to CONTRIBUTING.md. The travis check is failing because of that.

rniwa commented 7 years ago

Regardless, we shouldn't merge this change until Blink makes the behavioral change as I've stated in https://github.com/w3c/selection-api/issues/80.

TakayoshiKochi commented 7 years ago

I'm not sure whether CONTRIBUTING.md controls membership - am asking @sideshowbarker for help.

My understanding is that CONTRIBUTING.md file describes convention to attribute contributors who are not the primary author (obvious from the git commit log). Probably Travis is complaining about GitHub/W3C id mapping. So asking Mike Smith for help.

yoichio commented 7 years ago

Yes. Blink is going to change its behavior in few weeks. I want this PR to be ready to merge. In my understanding, this PR should pass that 'ipr check', right?

rniwa commented 7 years ago

I think so. It might be that I need to you add you first.

yoichio commented 7 years ago

Ping?

sideshowbarker commented 7 years ago

I notice @rniwa’s comment:

Regardless, we shouldn't merge this change until Blink makes the behavioral change as I've stated in #80.

So are we still waiting on that or not?

If we’re no longer waiting on that, I can go ahead and see that this gets merged with a note that the IPR bookeeping needs to be fixed post-merge.

There’s a bug in the IPR tool that the W3C systems team is investigating but has not yet fixed. But we should not block this on the tool bug getting fixed. @yoichio works for Google and Google has already made the RF commitments for the working group the Selection API spec belongs to. The only problem is a broken tool that doesn’t know that.

rniwa commented 7 years ago

It looks like Chrome changed its behavior last week: https://github.com/w3c/selection-api/issues/80#issuecomment-281544772

We can merge this change now. @sideshowbarker, it would be great if you can look into fixing IPR check so that we can just merge this change.