search

w3c / sensors

Generic Sensor API
https://www.w3.org/TR/generic-sensor/
Other
127 stars 59 forks source link

Clarify concepts section #348

Closed anssiko closed 6 years ago

anssiko commented 6 years ago

Preview | Diff

pozdnyakov commented 6 years ago

Looks good overall

anssiko commented 6 years ago

Thanks for the review! I've addressed your comments in https://github.com/w3c/sensors/pull/348/commits/4562f958a4ab773de4efb10d47fe21f8a8bca1d1

I also regenerated using the bikeshed HTTP API (rather than locally as be usually):

curl https://api.csswg.org/bikeshed/ -F file=@index.bs -F force=1 > index.html

And still there's index.html conflict. Ideas?

anssiko commented 6 years ago

Addressed @pozdnyakov's remaining comments, squashed all the review comments from this PR into https://github.com/w3c/sensors/pull/348/commits/55e3ee67807ccc4e616095a16fabe919fa138f6a and rebased that fixed the merge conflict.