search

w3c / sensors

Generic Sensor API
https://www.w3.org/TR/generic-sensor/
Other
127 stars 59 forks source link

Integrated WebDriver Extension API into to Generic Sensor spec #377

Closed Honry closed 5 years ago

Honry commented 5 years ago

This is just copy and paste to move WebDriver Extension API into a new section "Automation" in Generic Sensor spec with some necessary adjustment on the sections and editorial alignment.

Preview | Diff

Honry commented 5 years ago

@anssiko and all, PTAL. Thanks!

anssiko commented 5 years ago

Thanks @Honry!

Since the contents of this PR has already been reviewed in #369 I'll just focus my comments on how to possibly split test automation spec bits across specs.

All - would you prefer to see mock sensor types (sections 9.1.3.*) integrated into corresponding concrete sensor specs? That might make maintenance easier if/when those specs add new API surface that need to be accompanied with corresponding new mock sensor reading values.

Also, to acknowledge @Honry's contributions to testing and automation and make it clear to folks who to contact for testing related bits in the spec, I'd suggest adding the following to the headers:

!Test Facilitator: Wanming Lin (Intel Corporation)
Honry commented 5 years ago

@anssiko, thank you for the acknowledgment!

I think with a standalone issue would be better to track your suggestion on integration of mock sensor types into corresponding concrete sensor specs. And I just made it at https://github.com/w3c/sensors/issues/378, and please feel free to assign it to me. :)

reillyeon commented 5 years ago

The merge into this spec looks good. @anssiko are you okay with merging this PR as-is and then splitting out the mock sensor type definitions to the appropriate specs or should that work happen first?

anssiko commented 5 years ago

I'm fine with that. Let's merge. @Honry to take the lead in splitting the mock sensor types into appropriate concrete specs in separate PRs.