w3c / sensors

Generic Sensor API
https://www.w3.org/TR/generic-sensor/
Other
127 stars 59 forks source link

Stop referring to the "responsible document" concept. #433

Closed rakuco closed 2 years ago

rakuco commented 2 years ago

This has been removed from HTML. Instead, retrieve the document's relevant settings object (which is an environment as specified in HTML) and run the "is a secure context" check that is defined in HTML on it.

Fixes #432.

rakuco commented 2 years ago

cc @miketaylr

rakuco commented 2 years ago

@miketaylr / @anssiko friendly ping. Is there anything else you'd like me to address here?

rakuco commented 2 years ago

@anssiko thanks for reviewing. I don't have write access to this repository; can you land this one for me? It's also fine if you're waiting for Mike's feedback.

anssiko commented 2 years ago

@miketaylr please let us know if you'd like to adjust the "given document" part. I'll merge this now, and we'll update based on your suggestion as needed.

miketaylr commented 2 years ago

Apologies for showing up late. :)

I think it would be nice to formally define "given document" as the active document (or just use that in place), and tie the active document to a browsing context (something like "this's browsing context's active document").