w3c / sensors

Generic Sensor API
https://www.w3.org/TR/generic-sensor/
Other
127 stars 59 forks source link

Reword the "Conditions to expose sensor readings" section #434

Closed rakuco closed 2 years ago

rakuco commented 2 years ago

Follow-up to the review comments in #433.

The previous definition of "can expose sensor readings" was a bit too loose. It relied on a [=sensor type=] that was not passed to the operation and used "given document" to refer to the active document referenced in a prior paragraph.

Instead:

One possible improvement would be to normatively require all concrete Sensor classes to invoke "check sensor policy-controlled features" in their constructors, as this is currently done but not mandated.


Preview | Diff

rakuco commented 2 years ago

@miketaylr would you mind taking a look at this one as a follow-up to your comment in #433?

rakuco commented 2 years ago

@anssiko could you merge this PR as well?

anssiko commented 2 years ago

Sure thing, thanks for pinging me.