search

w3c / server-timing

Server Timing
http://w3c.github.io/server-timing/
Other
75 stars 20 forks source link

Correct encoded values in sample response body #62

Closed fj closed 5 years ago

fj commented 5 years ago

The &lt;s in the <pre> block of this example are being generated by respec from the pre block because of a missing <br>.

Preview | Diff

charmander commented 5 years ago

“should” why? That makes the HTML invalid.

cvazac commented 5 years ago

Respec is doing something funky here, but I'm not exactly sure what. But I think this will work:

  <pre class="example http">
    &gt; GET /resource HTTP/1.1
    &gt; Host: example.com
    <br/>
    &lt; HTTP/1.1 200 OK
    &lt; Server-Timing: miss, db;dur=53, app;dur=47.2
    &lt; Server-Timing: customView, dc;desc=atl
    &lt; Trailer: Server-Timing
    &lt; (... snip response body ...)
    &lt; Server-Timing: total;dur=123.4
  </pre>
cvazac commented 5 years ago

Try the preview: https://pr-preview.s3.amazonaws.com/fj/server-timing/pull/62.html

On Jan 17, 2019, at 10:55 PM, Charmander notifications@github.com wrote:

@cvazac What isn’t working already?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

charmander commented 5 years ago

@cvazac Sorry, I realized after enabling scripts.

dontcallmedom commented 5 years ago

Marked as non substantive for IPR from ash-nazg.

fj commented 5 years ago

After running respec locally and verifying with the preview I've verified that the example should now be displaying correctly.