search

w3c / spec-prod

GitHub Action to build ReSpec/Bikeshed specs, validate output and publish to GitHub pages or W3C
https://w3c.github.io/spec-prod/
MIT License
34 stars 21 forks source link

Upgrade vnu #188

Closed jyasskin closed 1 month ago

jyasskin commented 1 month ago

https://github.com/w3ctag/privacy-principles/actions/runs/11097000177/job/30827581027?pr=443 installed vnu 23.4.11 and complained that CSS using :has is invalid:

    ul:has(#include-websites) li { list-style:none }

    /* Show summary principles if their audience is selected. */
    #bp-summary li:has(.practicelab) { display: none }
    #bp-summary ul:has(#include-websites:checked) + #best-practices-summary li:has(.audience-websites) { display: list-item; }
    #bp-summary ul:has(#include-user-agents:checked) + #best-practices-summary li:has(.audience-user-agents) { display: list-item; }
    #bp-summary ul:has(#include-api-designers:checked) + #best-practices-summary li:has(.audience-api-designers) { display: list-item; }

The version at https://validator.w3.org/nu/?doc=https%3A%2F%2Fpr-preview.s3.amazonaws.com%2Fjyasskin%2Fprivacy-principles%2Fpull%2F443.html is 24.9.28 and doesn't complain about this CSS syntax.

jyasskin commented 1 month ago

@sideshowbarker, this might be something you can fix? The npm version seems to be significantly behind the website version?

sideshowbarker commented 1 month ago

Sorry for not replying sooner. I just now pushed a new npm version, 24.10.17.

If that doesn’t resolve this, lemme know

jyasskin commented 1 month ago

Thanks! That fixed it: https://github.com/w3ctag/privacy-principles/actions/runs/11097000177/job/31677684195?pr=443