search

w3c / specberus

Checker used at W3C to validate the compliance of Technical Reports with publication rules
https://www.w3.org/pubrules/
MIT License
72 stars 45 forks source link

Revert "chore(deps): bump puppeteer from 19.7.1 to 19.8.2" #1724

Closed deniak closed 1 year ago

deniak commented 1 year ago

Reverts w3c/specberus#1722

The new puppeteer version actually breaks specberus:

specberus/node_modules/puppeteer-core/lib/esm/puppeteer/common/Connection.js:118
        return callback.promise.finally(() => {
                                       ^

TypeError: callback.promise.finally is not a function
    at CallbackRegistry.create (specberus/node_modules/puppeteer-core/lib/esm/puppeteer/common/Connection.js:118:40)
    at Connection._rawSend (specberus/node_modules/puppeteer-core/lib/esm/puppeteer/common/Connection.js:212:26)
    at Connection.send (specberus/node_modules/puppeteer-core/lib/esm/puppeteer/common/Connection.js:206:21)
    at new ChromeTargetManager (specberus/node_modules/puppeteer-core/lib/esm/puppeteer/common/ChromeTargetManager.js:234:14)
    at new CDPBrowser (specberus/node_modules/puppeteer-core/lib/esm/puppeteer/common/Browser.js:136:69)
    at CDPBrowser._create (specberus/node_modules/puppeteer-core/lib/esm/puppeteer/common/Browser.js:45:25)
    at ChromeLauncher.launch (specberus/node_modules/puppeteer-core/lib/esm/puppeteer/node/ChromeLauncher.js:102:40)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Module.check (specberus/lib/rules/links/linkchecker.js:78:21)

Node.js v18.12.1