search

w3c / tdm-reservation-protocol

Repository of the Text and Data Mining Reservation Protocol Community Group
https://www.w3.org/community/tdmrep/
Other
7 stars 8 forks source link

Correct the examples & use W3C URL #12

Closed lrosenthol closed 3 years ago

lrosenthol commented 3 years ago

All of the examples were not valid as they did not include the @context for vcard - it has been added.

The use of a specific vendor's URL (eg. edrlab) is not appropriate for an open standard. Changed all references to w3c.org

llemeurfr commented 3 years ago

The necessity to add vcardin the context is surprising because https://www.w3.org/ns/odrl.jsonld contains its definition already. 

   "vcard":   "http://www.w3.org/2006/vcard/ns#",

Re. the use of an edrlab.org domain name, I used it as a placeholder. Not sure that the W3C will agree to have its domaine name used for this profile. I'll open an issue on this topic.

llemeurfr commented 3 years ago

Note also a comma missing after your context array.

lrosenthol commented 3 years ago

The necessity to add vcardin the context is surprising because https://www.w3.org/ns/odrl.jsonld contains its definition already.

See the examples at https://www.w3.org/TR/odrl-model/#policy-offer - they all explicitly add the vcard context.

llemeurfr commented 3 years ago

This PR is superseded by the modification of the spec in relation with #13.