w3c / tdm-reservation-protocol

Repository of the Text and Data Mining Reservation Protocol Community Group
https://www.w3.org/community/tdmrep/
Other
7 stars 8 forks source link

Example does not contain vcard context #37

Open RinkeHoekstra opened 6 months ago

RinkeHoekstra commented 6 months ago

The example in the spec does not include the VCard context http://www.w3.org/2006/vcard/ns, which means that VCard properties and values are not interpreted correctly.

https://github.com/w3c/tdm-reservation-protocol/blob/a1e0c76ac2cc9da602a8f916951c70a4c33b6b18/spec/index.html#L703-L733

llemeurfr commented 4 months ago

ok to add it in the next version of the spec.

llemeurfr commented 3 months ago

ah, I see now that https://www.w3.org/2006/vcard/ns is not a reference to a json-ld context file like https://www.w3.org/ns/odrl.jsonld or http://www.w3.org/ns/tdmrep.jsonld, but an OWL file: quite a different beast.

json-ld pre-defines a series of prefixes, including vcard, in https://github.com/w3c/json-ld-rc/blob/main/context.jsonld.

I copied a sample with vcard properties in https://json-ld.org/playground/ and had no error. Therefore it seems that we don't need to add a json-ld context file for vcard.

llemeurfr commented 3 months ago

and https://www.w3.org/ns/odrl.jsonld also contains the mapping of the vcard prefix.

If a json-ld context file is really needed, we should look at something like https://github.com/lanthaler/vCardOntology/blob/master/context.jsonld. But what is the official file? And is it really required?