search

w3c / testtwf-website

Centralized repository for all documentation pertaining to the W3C Open Web Platform testing effort (For PRs, see http://testthewebforward.org/docs/forkme.html )
http://testthewebforward.org
17 stars 42 forks source link

Creation of Seoul event page #222

Closed hollobit closed 10 years ago

hollobit commented 10 years ago

This is an event page for Seoul event. Please review it.

cynthia commented 10 years ago

I would do a history rewrite and make it into a clean commit (and correcting typos in commit message) before pulling, but that might be just me. Looking at the history, it doesn't seem like the requirements are too picky for commit cleanness.

rhauck commented 10 years ago

This page is still not building and it looks like a few steps are missing. Also, there's a lot of English text on this page that is referring to the Tokyo event, including the map. Rather than start the page from an existing event page, it might be cleaner to do it from the blank event template, which is documented inline: http://testthewebforward.org/events/kits/resources/site/page-template-en.html

Also, there are some other steps to have the event show up under 'Upcoming Events' and instruction on how to test if your page builds locally first - all documented here: http://testthewebforward.org/events/kits/resources/site/new-event-page-setup.html#event-page-creation

rhauck commented 10 years ago

The event page looks good to me now. There is one other change that has to be made to the entry _config.yml - in order for your event to appear under Upcoming Events, you have to add 'upcoming: true' as documented here: http://testthewebforward.org/events/kits/resources/site/new-event-page-setup.html#update-site-config

I'll merge this and I can make that one-line change so this page can go live. Nice work! Really excited you're having this event.