search

w3c / touch-events

https://w3c.github.io/touch-events/
26 stars 24 forks source link

Fix #66. Make all touch events composed events #67

Closed hayatoito closed 8 years ago

hayatoito commented 8 years ago

Regarding https://github.com/w3c/touch-events/pull/67, make all touch events composed events.

patrickhlauke commented 8 years ago

as I'm not completely au-fait with what composed events actually are/do, nor if there are any issues with a W3C spec referencing WHATWG (political or otherwise) ... @RByers, thoughts?

RByers commented 8 years ago

The clearest definition of composed seems to be in the note here:

True if event invokes listeners past a ShadowRoot node that is the root of its target attribute value, and false otherwise.

I think the general approach (of extending this spec and referring to the WHATWG DOM spec) is fine. When / if we ever go to publish a CR spec we may need to replace the reference to a W3C version, but presumably by then the W3C fork will be updated to also define composed.

I have a couple questions / concerns with the overall approach though - I'll follow up on w3c/webcomponents#513 and circle back here.

hayatoito commented 8 years ago

Thank you for the review.

When / if we ever go to publish a CR spec we may need to replace the reference to a W3C version, but presumably by then the W3C fork will be updated to also define composed.

I understand the concern. Actually, I thought the similar thing in creating the PR because it looks that most (all?) of W3C specification do not have a reference to a WHATWG Standard. It looks they try to avoid to have a reference to WHATWG. I am not 100% sure how we proceed in this case.

@annevk do you have any advice? Should I wait W3C version for incorporating Event.composed from WHATWG DOM?

If having a reference to WHATWG DOM is okay, I will try to make a PR for UIEvents at first here https://github.com/w3c/uievents/issues/89. After that, let me ask a merge of PR for Touch Events and Pointer Events, again.

annevk commented 8 years ago

There shouldn't be any issue referencing WHATWG documents. Happens all the time. I don't think anyone is maintaining the DOM fork either (which is annoying, since you have to know that is the case, it would be much easier if they just stopped copy-and-pasting without due process).

hayatoito commented 8 years ago

@annevk Thank you!

hayatoito commented 8 years ago

@RByers

PR for UI events has been merged https://github.com/w3c/uievents/pull/91. Could you review this PR now?

RByers commented 8 years ago

LGTM, thanks!