Closed palemieux closed 6 years ago
My review of the algorithm comes late. So, my comments are non-blocking to not interfere with the publication process.
I have some concerns. The recommended algorithm assumes that a presentation processor has access to the font properties of a font file when it calculates the resolved computed value. I doubt that this is the case.
This is also not an algorithm defined in CSS. To be more compliant with CSS one option would be to take the (very vague) text from CSS 2.1.
If a change is not possible, some terms in the algorithm may need to be clarified. What is the reference for the terms altitude
and descent
? To be clear some terms from a font format as open type should be used instead. This can be then used as reference for equivalent font formats.
The Working Group just discussed Update tts:lineHeight='normal' algorithm to match TTML2 ttml1#355
, and agreed to the following:
SUMMARY: @skynavga to make an editorial tweak from altitude to ascent in TTML2 and @palemieux to port that back into this pull request; @skynavga to raise an issue to add the special inheritance semantics back into TTML2.
Closes #354