search

w3c / ttml2

Timed Text Markup Language 2 (TTML2)
https://w3c.github.io/ttml2/
Other
41 stars 16 forks source link

Add #opacity-image feature designation (#883). #1133

Closed skynavga closed 5 years ago

skynavga commented 5 years ago

Closes #883.

nigelmegitt commented 5 years ago

This pull request needs an associated test in ttml2-tests.

skynavga commented 5 years ago

This PR does not actually add any new functionality, so unless you have a processor that actually does something with profiles, then it is a moot point. The only test would be whether a profile aware processor recognizes the new feature designation defined by this PR and aborts processing if it happens to not support the designated feature and a document requires a processor to support it. At this point, we don't have any tests that test any feature designation in this fashion.

nigelmegitt commented 5 years ago

I was thinking we should make sure we have a test that verifies that opacity as applied to image does have an effect, as a minimum. I will check to see if one is already present.

skynavga commented 5 years ago

@nigelmegitt I just checked, and it appears we do not, since our goal in TTML2 1ed testing was to test the set of features associated with the defined feature designations, and, since there was no feature designation for applying opacity to image, no test was required; so perhaps it is legitimate to ask what tests need to be added for features for which new feature designations are to be added; in any case, I don't believe this should block moving forward on the PR, but will be handled normally during the CR process for TTML2 2ed;

nigelmegitt commented 5 years ago

@skynavga don't forget that we did agree to write tests alongside pull requests so that a) we would not have a big push to write tests at CR stage and b) as a secondary mechanism for verifying that we are agreed on the intent of any substantive change.

skynavga commented 5 years ago

@nigelmegitt yes, I recall that, but I interpret that agreement as a guideline or goal, and not a concrete process rule; in general, we have not been overly diligent in following this guideline;

nigelmegitt commented 5 years ago

@skynavga true, and I promised to keep encouraging us to meet that goal, which is what I'm doing here!

skynavga commented 5 years ago

@nigelmegitt see https://github.com/w3c/ttml2-tests/pull/205