search

w3c / ttml2

Timed Text Markup Language 2 (TTML2)
https://w3c.github.io/ttml2/
Other
41 stars 16 forks source link

Update content models w.r.t. permissible styling attributes (#1155). #1157

Closed skynavga closed 4 years ago

skynavga commented 5 years ago

Closes #1155.

This PR is untestable for the same reasons described at https://github.com/w3c/ttml2/pull/1096#issuecomment-513468050.

nigelmegitt commented 5 years ago

I think this is in fact testable, since it is constraining the set of styling attributes that are permitted. Therefore an invalidity test can be constructed that includes an animate or set element (or both) that targets tts:ruby, for example.

skynavga commented 5 years ago

@nigelmegitt yes, that is true, but only for the changes to the content models of animate and set; however, I planned to add tests for that constrain (can't target non-animatable styles) in the context of #1154, which adds other language proscribing this usage without needing the change in content model to do so

nigelmegitt commented 5 years ago

@skynavga okay, that would work too.