migrated TravisCI to GitHub Actions

w3c / ttml2

Timed Text Markup Language 2 (TTML2)

https://w3c.github.io/ttml2/

Other

40 stars 16 forks source link

migrated TravisCI to GitHub Actions #1238

Closed himorin closed 2 years ago

himorin commented 3 years ago

for https://github.com/w3c/ttwg/issues/198

himorin commented 3 years ago

how about this?

github-actions[bot] commented 3 years ago

Preview: https://github.com/w3c/ttml2/tree/update-to-ghactions-build

nigelmegitt commented 3 years ago

Thanks @himorin that's a good improvement - these could be separate pull requests, but I wonder if it's possible also to:

put the preview link on the first comment on the pull request, rather than adding an inline comment;
add a link to a served version of the specification built HTML itself so that it can be directly viewed;
diff the build HTML with the version on the pull request target branch, store that, and link to that too, like PR-preview does;

github-actions[bot] commented 3 years ago

Preview | diff

himorin commented 3 years ago

For first point, it's (not a bit) somehow difficult to do with current way of building action script...

For second and third, how about this?

nigelmegitt commented 3 years ago

That's great! I think it might overload the diff service though: if there's a way to store the result and point to that directly then the sys team might be a bit happier, I'm guessing.

github-actions[bot] commented 3 years ago

Preview | diff

himorin commented 3 years ago

That's great! I think it might overload the diff service though: if there's a way to store the result and point to that directly then the sys team might be a bit happier, I'm guessing.

unfortunately, (it seems) htmlpreview script conflicts with htmldiff script as above.

skynavga commented 2 years ago

@nigelmegitt could you do a final review?

himorin commented 2 years ago

@nigelmegitt @skynavga thank you for review comments. I haven't noticed about the case with target as non-gh-branch... it could be possible to build diff at such situation. But somehow difficult considering possible situations such as no ready made built files for target working branch (should not be, since we are operating automatic build for PRs raised against here - but it means non PR one will not have such build), or getting additional information for building these.... So, let me give up on such cases.

And, let me raise PRs to relevant repositories using TravisCI for building spec doc (and hopefully) shortly.

himorin commented 2 years ago

I've found a serious issue while pushing to other targets. I'll raise new PR shortly.