fix radii example - Githubissues

w3c / ttml2

Timed Text Markup Language 2 (TTML2)

https://w3c.github.io/ttml2/

Other

40 stars 16 forks source link

fix radii example #1249

Closed MarcAntoine-Arnaud closed 1 year ago

MarcAntoine-Arnaud commented 1 year ago

@cconcolato what can be fixed to pass checks ?

cconcolato commented 1 year ago

@cconcolato what can be fixed to pass checks ?

There are 2 failures:

One is the IPR rule because you are not a WG member. I don't know if it can be overridden. It should because your PR is not bringing any IP at all.
The other one seems a pure GitHub issue.

@himorin can you have a look?

MarcAntoine-Arnaud commented 1 year ago

I have submit this afternoon to be member of the WG. If it can help!

w3cbot commented 1 year ago

himorin marked as non substantive for IPR from ash-nazg.

nigelmegitt commented 1 year ago

I think there's at least a strong chance that the PR build failure is because the PR branch is from a fork. I will try it from an in-repo branch and see if it succeeds.

himorin commented 1 year ago

I think there's at least a strong chance that the PR build failure is because the PR branch is from a fork. I will try it from an in-repo branch and see if it succeeds.

Ah,, could be. I need to check in deep of current GHAction, but such issue could happen since current script just uses git push to create preview branch (= github deploy key mismatch)..

nigelmegitt commented 1 year ago

Opened #1251 from a branch created in the repo, which just imports @MarcAntoine-Arnaud 's commit and passes all the tests. Closing this in favour of that. I think the way I've done this does not remove the log showing that this is @MarcAntoine-Arnaud 's contribution, for which, thank you!

nigelmegitt commented 1 year ago

Just to follow up, #1251 merged, which incorporates this change @MarcAntoine-Arnaud. Thank you again!