search

w3c / ttml2

Timed Text Markup Language 2 (TTML2)
https://w3c.github.io/ttml2/
Other
40 stars 16 forks source link

not push new branch for PR from forked repository #1256

Closed himorin closed 1 year ago

himorin commented 1 year ago

as title.

(note, as test, PR is made from forked repository)

himorin commented 1 year ago 
    data: {
      message: 'Resource not accessible by integration',
      documentation_url: 'https://docs.github.com/rest/reference/issues#create-an-issue-comment'
    }

it seems adding comment is not allowed for this pattern, neither...

himorin commented 1 year ago

@nigelmegitt I assume this is what I've proposed (in DM).

himorin commented 1 year ago

Seems to work, but I can't easily check it doesn't break PRs opened against the w3c repo. Anyway at least with this specific PR I can see that the checks pass without the push error, which is a good step forward.

Yeah, that is the point which I cannot verify with this PR / check passed. This PR does add some non-applicable criteria, but does not add any criteria to fail, so I believe there should no additional break (but may add possible false negative of checker...).

Let me merge this, and check with one PR just for check (no intended to be merged)?

nigelmegitt commented 1 year ago

Let me merge this, and check with one PR just for check (no intended to be merged)?

Please go ahead.

himorin commented 1 year ago

Yes. I'll add PRs for testing.