search

w3c / uievents

UI Events
https://w3c.github.io/uievents/
Other
145 stars 52 forks source link

Change initKeyboardEvent to be compatible with Blink/WebKit #153

Closed ayg closed 7 years ago

ayg commented 7 years ago

Gecko is the only UA that doesn't implement initKeyboardEvent, and is looking to implement it to improve interoperability. However, the parameter list in Blink and WebKit differs from the list in the spec, which seemingly matches IE. We would like to implement the Blink/WebKit version because we believe it would be more compatible, so we would like the spec to change to match it. This will also require only Edge to change its existing implementation instead of both Blink and WebKit, so it will be easier to achieve interoperability. (Assuming Edge's implementation matches Microsoft documentation.)

The parameters are taken from Blink's implementation, except that the first parameter is left mandatory although in Blink it's optional. Gecko tried implementing the method with all parameters mandatory but had to revert it because of incompatibility. WebKit adds one more parameter "altGraphKey" that I didn't put in the spec.

References:

Microsoft docs: https://msdn.microsoft.com/en-us/library/ff975297(v=vs.85).aspx Blink IDL: https://src.chromium.org/viewvc/blink/trunk/Source/core/events/KeyboardEvent.idl?revision=198345#l43 WebKit IDL: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/dom/KeyboardEvent.idl?rev=209895#L52 Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1387828

I also updated the HTML40 and XFORMS references to HTML401 and XFORMS11 to silence bikeshed errors that they were obsolete.

Related to #112.

ayg commented 7 years ago

@garykac Any ETA on review? I would like to update Gecko to be interoperable here, but it's blocked on the spec change, and after a week from Tuesday I don't think I'm going to be able to do it.

(I don't know why the IPR tool is complaining, my W3C account is linked to my GitHub account and I should be registered as a member of Mozilla.)

garykac commented 7 years ago

I'm on vacation now, but your PR looks good to me.

We need to figure out the IPR problem - you're not the only one being hit by that so I think we have something set up incorrectly.

ayg commented 7 years ago

Thanks!

ayg commented 7 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1387828

chaals commented 7 years ago

Regarding the IPR issue, I believe Mozilla is a member of the group but has not signed up under the recently renewed charter. There is a 45-day period to do so, but the current tooling doesn't handle that as far as I know. Ping @dontcallmedom

dontcallmedom commented 7 years ago

@chaals as far as I can tell, the 45-days grace period is only about attending meetings, not about making substantive contributions.