Various comments on coupon commands - Githubissues

w3c / validator-suite

Validator Suite

Other

56 stars 23 forks source link

Various comments on coupon commands #369

Closed vivienlacourba closed 10 years ago

vivienlacourba commented 10 years ago

Check the coupon code syntax while creating a new coupon with the coupon-create command, as currently it is possible to create 1234 as a coupon. e.g.

> coupon-create 1234 toto 10
52e286696ef5f15e0008333b - Code: 1234 - Campaign: toto - Credits: 10 - Expires: 2014-04-24T15:27:37.712Z - UseDate: None - UsedBy: None

Check the prefix syntax (2 to 8 number or letter) in the coupon-campaign-create command as otherwise we would generate invalid coupons
Remove coupon commands that use <code> as the key and only keep the ones that uses the coupon id (also rewrite <id> in <couponId> to match the user and job commands).
Catch exceptions in command mode too

> coupon-create 1234 titi 20
coupon.error.duplicate
    org.w3.vs.model.Coupon$$anonfun$save$1.applyOrElse(Coupon.scala:180)
    org.w3.vs.model.Coupon$$anonfun$save$1.applyOrElse(Coupon.scala:179)
...

vivienlacourba commented 10 years ago

It is still possible to create from the console a coupon with an invalid code from (see first bullet).

The following command still uses <code> instead of <couponId> (see third bullet): coupon-redeem <code> <userId> - redeem a coupon to a userId