w3c / vc-bitstring-status-list

A privacy-preserving mechanism to publish status information for Verifiable Credentials.
https://w3c.github.io/vc-bitstring-status-list/
Other
22 stars 19 forks source link

Added changes to the vocabulary per #158 #159

Closed iherman closed 7 months ago

iherman commented 8 months ago

This PR implements the changes proposed in #158, adds a diagram (with its textual description) to the generated HTML+RDFa file to be in line in style with the other vocabularies.

As usual, the built-in preview would not help for the generated vocabulary files and the diagrams. The preview page to be used is here: https://w3c.github.io/yml2vocab/previews/sl/

iherman commented 8 months ago

Note to myself/ourselves: if this PR is approved in such a way that the xsd:positiveInteger is used as the range of statusSize, then the crdential context file must be updated as well. At the moment, it says (in line 214-215)

        "statusReference": "https://www.w3.org/ns/credentials/status#statusReference",
        "statusSize": "https://www.w3.org/ns/credentials/status#statusSize",

this should be changed to

    "statusReference"  : {
       "@id" : "https://www.w3.org/ns/credentials/status#statusReference",
       "@type" : "@id"
    },
    "statusSize": {
       "@id" : "https://www.w3.org/ns/credentials/status#statusSize",
       "@type": "https://www.w3.org/2001/XMLSchema#positiveInteger"
    }

cc @dlongley @msporny @davidlehn

TallTed commented 7 months ago

Would xsd:nonNegativeInteger be more appropriate than xsd:positiveInteger, i.e., could the value of statusSize ever be 0?

iherman commented 7 months ago

Would xsd:nonNegativeInteger be more appropriate than xsd:positiveInteger, i.e., could the value of statusSize ever be 0?

The specification says:

If statusSize is not present as a property of the credentialStatus, then statusSize MUST be processed as 1. statusSize MUST be an integer greater than zero.

I am just a go-between 😀

iherman commented 7 months ago

The issue was discussed in a meeting on 2024-04-03

View the transcript #### 3.5. Added changes to the vocabulary per #158 (pr vc-bitstring-status-list#159) _See github pull request [vc-bitstring-status-list#159](https://github.com/w3c/vc-bitstring-status-list/pull/159)._ **Ivan Herman:** there is one PR #159 which has to be done before CR. … this is related to mechanics of the repository. … the vocab is wrong, we have to change the context file, ... there are some changes we need to get in before CR. > *Manu Sporny:* +1 to making the changes Ivan is suggesting :). **Gabe Cohen:** not to folks, please review 159. > *Manu Sporny:* You have 4 positive reviews now, Ivan. :). **Gabe Cohen:** that wraps up the schedule. any other items. … that's a wrap. Please review the issues, especially on bitstring status list and VCDM. … next week VC-JOSE-COSE considered for CR. ---
msporny commented 7 months ago

Editorial, multiple positive reviews, questions asked were answered, no changes requested, no objections, merging.

iherman commented 7 months ago

For the record, https://github.com/w3c/vc-data-model/pull/1471 has been raised to complete the changes described in https://github.com/w3c/vc-bitstring-status-list/pull/159#issuecomment-2027965995.