w3c / vc-data-integrity

W3C Data Integrity Specification
https://w3c.github.io/vc-data-integrity/
Other
42 stars 19 forks source link

Do not assume errors can be surfaced #157

Closed msporny closed 1 year ago

msporny commented 1 year ago

All of the current algorithms presume that errors can be surfaced and use "MUST" language related to error codes. For example:

https://www.w3.org/TR/2023/WD-vc-data-integrity-20230805/#add-proof https://www.w3.org/TR/2023/WD-vc-data-integrity-20230805/#verify-proof

Some libraries are not capable of exposing detailed errors and/or codes. The algorithms should be reworked such that throwing an error is required (MUST), but the conveyance of the error code/message is done on a best effort basis (SHOULD).

msporny commented 1 year ago

PR #158 has been raised to address this issue. This issue will be closed once that PR is merged.

msporny commented 1 year ago

PR #158 has been merged, closing.