search

w3c / vc-data-integrity

W3C Data Integrity Specification
https://w3c.github.io/vc-data-integrity/
Other
42 stars 19 forks source link

Add multibase datatype definition #176

Closed msporny closed 1 year ago

msporny commented 1 year ago

This PR addresses https://github.com/w3c/vc-data-integrity/pull/162#discussion_r1292500235 by defining the multibase datatype as we recently did for cryptosuiteString. It then updates proofValue's range to be multibase.

@iherman, we'll need to define the datatype in the vocabulary.yml file as well, but I didn't see how that was done for cryptosuiteString yet -- perhaps that still needs to be merged?

Preview | Diff

iherman commented 1 year ago

@iherman, we'll need to define the datatype in the vocabulary.yml file as well, but I didn't see how that was done for cryptosuiteString yet -- perhaps that still needs to be merged?

Yes, that is part of #171 .

(would be good to merge that one, to avoid unnecessary issues...)

iherman commented 1 year ago

This PR addresses #162 (comment) by defining the multibase datatype as we recently did for cryptosuiteString. It then updates proofValue's range to be multibase.

Forgive me if my question reveals my missing knowledge, but shouldn't this be the range of secretKeyMultibase and publicKeyMultibase, too? At this moment, those two properties have simply xsd:string as their range.

msporny commented 1 year ago

Forgive me if my question reveals my missing knowledge, but shouldn't this be the range of secretKeyMultibase and publicKeyMultibase, too? At this moment, those two properties have simply xsd:string as their range.

Yes, good catch, I'll make that change in a future revision to this PR.

msporny commented 1 year ago

@iherman wrote:

Forgive me if my question reveals my missing knowledge, but shouldn't this be the range of secretKeyMultibase and publicKeyMultibase, too? At this moment, those two properties have simply xsd:string as their range.

Done in https://github.com/w3c/vc-data-integrity/pull/176/commits/78c30c0919bbf7fce3adf8cf2ccb49a1e920d9e4.

msporny commented 1 year ago

Normative, multiple reviews, changes requested and made, no objections, merging.