search

w3c / vc-data-integrity

W3C Data Integrity Specification
https://w3c.github.io/vc-data-integrity/
Other
40 stars 18 forks source link

representation-eddsa-rdfc-2022 Test Vector Issue #204

Closed a-c-brown closed 6 months ago

a-c-brown commented 11 months ago

The Canonical Proof Options in the representation-eddsa-rdfc-2022 test vector appears to differ from that produced by the JSON-LD Playground and PyLD 1.1.

If true please update Examples 12, 13, 14, 15, 16 , and 17. Thanks for your time.

image

dlongley commented 11 months ago

@a-c-brown,

Yes, thanks for reporting this. This particular item (cryptosuiteString) was just adjusted in the context prior to preparing for CR and we were waiting to regenerate the test vectors until after it was done. There's one more PR in to adjust the context (#202), but that shouldn't affect this particular issue if we want to regen those test vectors now.

cc: @Wind4Greg

a-c-brown commented 11 months ago

@a-c-brown,

Yes, thanks for reporting this. This particular item (cryptosuiteString) was just adjusted in the context prior to preparing for CR and we were waiting to regenerate the test vectors until after it was done. There's one more PR in to adjust the context (#202), but that shouldn't affect this particular issue if we want to regen those test vectors now.

cc: @Wind4Greg

Thanks @dlongley - those test vectors are extremely useful so I appreciate you having them available.

Wind4Greg commented 11 months ago

@a-c-brown Glad the test vectors are helping. Your review and confirmation of the vectors are important! The code used to generate the test vectors is open source and can be found at EdDSA-Test-Vectors. @dlongley so its now a good time to regenerate all the EdDSA and ECDSA test vectors?

dlongley commented 11 months ago

@Wind4Greg,

Yes, I think we should regenerate them now -- I expect there to be a possible need to regen them again for proof chains because of the previous proof property PR that isn't in yet, but hopefully that will be the last time. The regen'd vectors that are for proof sets should be unchanged (I'd think) once that PR lands.

msporny commented 6 months ago

Test vectors were updated months ago in w3c/vc-di-eddsa#64, closing.