Closed msporny closed 10 months ago
We should add an example that demonstrates how to secure an internationalized string.
The issue was discussed in a meeting on 2023-10-17
PR #213 has been raised to address this issue. This issue will be closed once PR #213 has been merged.
Pasting in the I18N comment:
Example 1 https://www.w3.org/TR/vc-data-integrity/#example-a-simple-json-data-document
{ "title": "Hello world!" };
Also found in the other docs in this review, e.g.
There are a number of examples that have title as a string (as shown above). These ought to use the language and direction metadata we've discussed in data model or use a non-language string as the example.
There are a number of examples that have title as a string (as shown above).
The examples in the core spec have been updated to use a non-language string as the example. The test vectors will need to be updated later as @Wind4Greg is soon-to-be/currently on leave and unable to update the test vectors. Since the test vectors are non-normative, we can update them at any time. I've added a tracking issue for this to make sure that we do this as soon as @Wind4Greg is back: https://github.com/w3c/vc-data-integrity/issues/218
PR #213 has been merged, closing.
A quick i18n review by @aphillips requested that we demonstrate i18n best practices:
https://github.com/w3c/i18n-activity/issues/1771
This issue tracks that concern such that it's addressed before the DI specs go to CR.