w3c / vc-data-integrity

W3C Data Integrity Specification
https://w3c.github.io/vc-data-integrity/
Other
40 stars 18 forks source link

Binding Proof Chains Together #224

Closed Wind4Greg closed 8 months ago

Wind4Greg commented 9 months ago

The current algorithm in section 4.4 Add Proof Set/Chain doesn't bind proofs in a chain with each other. This slight modification of the algorithm achieves this result. This PR:

  1. Modifies section 4.4 Add Proof Set/Chain to provide this binding. Thanks to @dlongley for suggesting the mechanism.
  2. Modifies section 4.6 Verify Proof Sets and Chains to work with the improved algorithm
  3. Modifies section 4.8 Processing Errors to formally define the PROOF_CHAIN_CYCLE_ERROR that was in the text but not defined.

Files for generating test vectors for these updated procedures have been created at https://github.com/Wind4Greg/EdDSA-Test-Vectors/tree/proof-chains.


Preview | Diff

msporny commented 8 months ago

Normative, multiple reviews, changes requested and made, no objections, merging.