search

w3c / vc-data-integrity

W3C Data Integrity Specification
https://w3c.github.io/vc-data-integrity/
Other
40 stars 18 forks source link

Make Verify Proof match the interface used by JOSE/COSE proof verification #227

Closed jyasskin closed 8 months ago

jyasskin commented 8 months ago

This builds on #226 to enable a change to vc-data-model that I hope will address https://github.com/w3c/vc-data-model/issues/1377. @OR13, do you see where I'm going with this, and am I right that it'll fix the problem? Everyone else, does this look like a sensible interface for this operation?

I'm setting this to draft until #226 is merged; please only review the changes that aren't included in that PR.

Preview | Diff

jyasskin commented 8 months ago

This is now rebased; the conflict was just in a change to the step numbers in a reference to another algorithm. I'll mark this as ready for review since @msporny has approved #226.

msporny commented 8 months ago

@jyasskin conflicts again based on merging your other PR. Please fix again and I'll try to get this in before anything else gets out of sync.

jyasskin commented 8 months ago

@msporny Rebased, thanks!

msporny commented 8 months ago

Normative, multiple reviews, changes requested (and will be made in a future PR), no objections, merging.